Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): self-update is pending #2272

Merged
merged 2 commits into from May 8, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 temporarily deployed to development May 8, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:02 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 11:15pm
affine-storybook 🔄 Building (Inspect) May 8, 2023 11:15pm

@himself65 himself65 temporarily deployed to development May 8, 2023 23:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:07 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -24.74 ⚠️

Comparison is base (4f99ad2) 69.29% compared to head (30332ac) 44.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2272       +/-   ##
===========================================
- Coverage   69.29%   44.55%   -24.74%     
===========================================
  Files         281      224       -57     
  Lines        6142     4962     -1180     
  Branches      898      760      -138     
===========================================
- Hits         4256     2211     -2045     
- Misses       1669     2651      +982     
+ Partials      217      100      -117     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test ?
unittest 36.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponent/src/components/app-sidebar/index.jotai.ts 30.76% <0.00%> (-38.47%) ⬇️

... and 255 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 30332ac
Status: ✅  Deploy successful!
Preview URL: https://9877252f.affine.pages.dev
Branch Preview URL: https://himself65-0408-fix-app-updat.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development May 8, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 23:14 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 8, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ix-app-update                 +/- ##
===================================================================
< Bundle              3.11 MB        3.14 MB    +33.2 kB(+1.07%)   
< Initial JS          1.86 MB        1.87 MB    +11.2 kB(+0.60%)   
< Initial CSS         16.8 kB        18.3 kB    +1.54 kB(+9.19%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             45                  +4   
< Chunks                   39             42                  +3   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ix-app-update                 +/- ##
===================================================================
< Bundle                 3 MB        3.02 MB    +23.8 kB(+0.79%)   
< Initial JS          1.75 MB        1.75 MB    +1.88 kB(+0.11%)   
< Initial CSS         16.8 kB        18.3 kB    +1.54 kB(+9.19%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             43                  +4   
< Chunks                   37             40                  +3   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ix-app-update                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 merged commit 1e8c5a4 into master May 8, 2023
6 checks passed
@himself65 himself65 deleted the himself65/0408-fix-app-update branch May 8, 2023 23:16
@vercel vercel bot temporarily deployed to Preview – affine-preview May 8, 2023 23:31 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 8, 2023 23:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant