Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to fix updater not working #2294

Merged
merged 5 commits into from
May 10, 2023
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 10, 2023

also fix #2293

@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:27 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:31am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:31am

@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:27 — with GitHub Actions Inactive
@github-actions github-actions bot added the app:electron Related to electron app label May 10, 2023
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:30 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4457cfb
Status: ✅  Deploy successful!
Preview URL: https://f98a1604.affine.pages.dev
Branch Preview URL: https://0510-fix-electron-updater.affine.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.15 ⚠️

Comparison is base (ef665df) 71.19% compared to head (4457cfb) 71.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2294      +/-   ##
==========================================
- Coverage   71.19%   71.04%   -0.15%     
==========================================
  Files         322      322              
  Lines        7134     7139       +5     
  Branches     1126     1127       +1     
==========================================
- Hits         5079     5072       -7     
- Misses       1848     1861      +13     
+ Partials      207      206       -1     
Flag Coverage Δ
e2etest 67.80% <ø> (-0.19%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 55.43% <ø> (ø)
unittest 40.54% <16.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ectron/layers/main/src/handlers/updater/updater.ts 16.66% <0.00%> (-0.99%) ⬇️
.../electron/layers/main/src/handlers/db/ensure-db.ts 91.11% <100.00%> (+0.41%) ⬆️
...electron/layers/main/src/handlers/dialog/dialog.ts 72.00% <100.00%> (ø)
apps/electron/layers/main/src/handlers/register.ts 82.35% <100.00%> (+1.10%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 04:32 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 10, 2023 04:43 Inactive
@perfsee
Copy link

perfsee bot commented May 10, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ctron-updater                 +/- ##
===================================================================
< Bundle              3.11 MB        3.16 MB    +54.8 kB(+1.76%)   
< Initial JS          1.86 MB        1.88 MB    +17.6 kB(+0.95%)   
< Initial CSS         16.8 kB        26.5 kB   +9.74 kB(+58.13%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             49                  +8   
< Chunks                   39             43                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ctron-updater                 +/- ##
===================================================================
< Bundle                 3 MB        3.04 MB    +45.4 kB(+1.51%)   
< Initial JS          1.75 MB        1.76 MB    +8.21 kB(+0.47%)   
< Initial CSS         16.8 kB        26.5 kB   +9.74 kB(+58.13%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             47                  +8   
< Chunks                   37             41                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ctron-updater                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 10, 2023 04:47 Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:15 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:18 — with GitHub Actions Inactive
@github-actions github-actions bot added the test label May 10, 2023
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:21 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 10, 2023 05:25 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 10, 2023 05:27 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 10, 2023 05:31 Inactive
@himself65 himself65 enabled auto-merge (squash) May 10, 2023 05:40
@himself65 himself65 merged commit e4f13dd into master May 10, 2023
10 checks passed
@himself65 himself65 deleted the 0510/fix/electron-updater branch May 10, 2023 05:40
himself65 added a commit that referenced this pull request May 10, 2023
Co-authored-by: Himself65 <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

An unexpected error in the feature of Storage Folder​
2 participants