Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): toast too many times when switch page mode #2296

Merged
merged 1 commit into from
May 10, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented May 10, 2023

Fixes: #2289

@himself65 himself65 requested a review from JimmFly May 10, 2023 05:39
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:49am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:49am

@himself65 himself65 temporarily deployed to development May 10, 2023 05:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:43 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 10, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …65/0510-toast                 +/- ##
===================================================================
< Bundle              3.11 MB        3.16 MB    +55.1 kB(+1.77%)   
< Initial JS          1.86 MB        1.88 MB    +17.9 kB(+0.96%)   
< Initial CSS         16.8 kB        26.5 kB   +9.74 kB(+58.13%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             49                  +8   
< Chunks                   39             43                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …65/0510-toast                 +/- ##
===================================================================
< Bundle                 3 MB        3.04 MB    +45.6 kB(+1.52%)   
< Initial JS          1.75 MB        1.76 MB    +8.46 kB(+0.48%)   
< Initial CSS         16.8 kB        26.5 kB   +9.74 kB(+58.13%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             47                  +8   
< Chunks                   37             41                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …65/0510-toast                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 10, 2023 05:44 Inactive
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 413ab4d
Status: ✅  Deploy successful!
Preview URL: https://f80b0ddc.affine.pages.dev
Branch Preview URL: https://himself65-0510-toast.affine.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.30 ⚠️

Comparison is base (ef665df) 71.19% compared to head (413ab4d) 70.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
- Coverage   71.19%   70.89%   -0.30%     
==========================================
  Files         322      322              
  Lines        7134     7140       +6     
  Branches     1126     1128       +2     
==========================================
- Hits         5079     5062      -17     
- Misses       1848     1869      +21     
- Partials      207      209       +2     
Flag Coverage Δ
e2etest 67.55% <60.00%> (-0.44%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 55.43% <ø> (ø)
unittest 40.47% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/web/src/hooks/root/use-on-transform-workspace.ts 50.00% <ø> (ø)
...uite/workspace-header/editor-mode-switch/index.tsx 63.15% <55.55%> (-1.13%) ⬇️
apps/web/src/utils/toast.ts 85.71% <100.00%> (+2.38%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 10, 2023 05:49 Inactive
@himself65 himself65 merged commit 19e20a6 into master May 10, 2023
14 checks passed
@himself65 himself65 deleted the himself65/0510-toast branch May 10, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:web mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

No toast notification needed when page/edgeless mode remains unchanged
1 participant