Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tour modal #2297

Merged
merged 4 commits into from
May 10, 2023
Merged

refactor: tour modal #2297

merged 4 commits into from
May 10, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 10, 2023

2023-05-10.15.26.42.mov

@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:51 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 8:08am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 8:08am

@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:51 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 64c177c
Status: ✅  Deploy successful!
Preview URL: https://fc2e6fe3.affine.pages.dev
Branch Preview URL: https://refactor-tour-modal.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:54 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -17.88 ⚠️

Comparison is base (beabd1e) 71.04% compared to head (64c177c) 53.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2297       +/-   ##
===========================================
- Coverage   71.04%   53.16%   -17.88%     
===========================================
  Files         322      258       -64     
  Lines        7141     5816     -1325     
  Branches     1131      942      -189     
===========================================
- Hits         5073     3092     -1981     
- Misses       1862     2616      +754     
+ Partials      206      108       -98     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test 54.88% <42.85%> (-0.31%) ⬇️
unittest 40.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/component/src/ui/modal/modal-wrapper.tsx 100.00% <ø> (ø)
...component/src/components/tour-modal/tour-modal.tsx 53.84% <42.85%> (-12.83%) ⬇️

... and 190 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 10, 2023 06:55 Inactive
@JimmFly JimmFly requested a review from himself65 May 10, 2023 06:57
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 06:58 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:00 — with GitHub Actions Inactive
@github-actions github-actions bot added app:electron Related to electron app test labels May 10, 2023
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:03 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 10, 2023 08:04 Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 10, 2023 08:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 10, 2023 08:08 Inactive
@JimmFly JimmFly merged commit 1f48bc4 into master May 10, 2023
11 checks passed
@JimmFly JimmFly deleted the refactor/tour-modal branch May 10, 2023 08:11
himself65 pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:component mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants