Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add useBlocksuiteEditor hooks #5366

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat: add useBlocksuiteEditor hooks #5366

merged 1 commit into from
Dec 28, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 21, 2023 •
edited

No description provided.

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 21, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@JimmFly Graphite App
Copy link
Member Author

JimmFly commented Dec 21, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (431f7cf) 67.21% compared to head (e11e827) 67.21%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           canary    #5366   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files         190      190           
  Lines       15384    15384           
  Branches     1059     1059           
=======================================
  Hits        10341    10341           
  Misses       4900     4900           
  Partials      143      143
Flag Coverage Δ
server-test 69.62% <ø> (ø)
unittest 54.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pengx17
pengx17 requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve my comments

@JimmFly JimmFly requested a review from pengx17 December 27, 2023 07:54
@pengx17 Graphite App
Copy link
Collaborator

pengx17 commented Dec 27, 2023

So the new impl does not support multiple editors?

@JimmFly
Copy link
Member Author

JimmFly commented Dec 27, 2023 •
edited

So the new impl does not support multiple editors?

Apologies, it seems I’ve misconstrued your meaning. I interpreted the comment as suggesting that the editor atom didn’t require correspondence with the pageid. @pengx17

Also the API does not consider the case that two editors share the same pageId

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 28, 2023 •
edited

Merge activity

@graphite-app graphite-app bot merged commit e11e827 into canary Dec 28, 2023
36 checks passed
@graphite-app graphite-app bot deleted the jimmfly/1221/editor-hooks branch December 28, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengx17 pengx17 pengx17 approved these changes

@EYHN EYHN EYHN approved these changes

@CatsJuice CatsJuice CatsJuice approved these changes

@joooye34 joooye34 Awaiting requested review from joooye34

Assignees

@JimmFly JimmFly

Labels
app:core mod:component mod:hooks
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JimmFly @pengx17 @EYHN @CatsJuice