fix(component): fix font display on safari #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5393 +/- ##
==========================================
+ Coverage 67.12% 67.14% +0.01%
==========================================
Files 188 188
Lines 15378 15378
Branches 1059 1059
==========================================
+ Hits 10322 10325 +3
+ Misses 4913 4912 -1
+ Partials 143 141 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Wow good finding! It seems the @font-face/font-weight property in Safari is |
pengx17
approved these changes
Dec 26, 2023
Merge activity
|
before  after 
Brooooooklyn
force-pushed
the
eyhn/fix/font
branch
from
4d0f5a8
to
7a770f9
Compare
joooye34
pushed a commit
that referenced
this pull request
Dec 27, 2023
before  after 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after