Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avatars are not aligned #5404

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 26, 2023

before:
image

after:
image

Copy link

graphite-app bot commented Dec 26, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

JimmFly commented Dec 26, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c59a6a8) 59.56% compared to head (89ed7ff) 45.65%.
Report is 1 commits behind head on canary.

❗ Current head 89ed7ff differs from pull request most recent head 5b053a4. Consider uploading reports for the commit 5b053a4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5404       +/-   ##
===========================================
- Coverage   59.56%   45.65%   -13.91%     
===========================================
  Files         512      410      -102     
  Lines       22207     9318    -12889     
  Branches     1981     1325      -656     
===========================================
- Hits        13227     4254     -8973     
+ Misses       8639     4748     -3891     
+ Partials      341      316       -25     
Flag Coverage Δ
e2e-plugin-test 39.77% <ø> (ø)
server-test ?
unittest 54.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/1226/fix-avatar branch 2 times, most recently from 89ed7ff to 5b053a4 Compare December 26, 2023 08:03
@joooye34 joooye34 merged commit 62fbab4 into canary Dec 26, 2023
62 of 67 checks passed
@joooye34 joooye34 deleted the jimmfly/1226/fix-avatar branch December 26, 2023 12:23
joooye34 pushed a commit that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants