Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(infra): remove old plugin system #5411

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 26, 2023

plugin system need redesign

Copy link

graphite-app bot commented Dec 26, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Dec 26, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added mod:infra Environment related issues and discussions docs Improvements or additions to documentation mod:env app:electron Related to electron app mod:dev plugin:copilot test Related to test cases mod:plugin app:core mod:plugin-cli mod:sdk labels Dec 26, 2023
@EYHN EYHN force-pushed the eyhn/remove/plugin branch 2 times, most recently from ad4ae06 to a26b246 Compare December 26, 2023 13:36
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3903a1c) 59.56% compared to head (265ee81) 67.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5411      +/-   ##
==========================================
+ Coverage   59.56%   67.12%   +7.55%     
==========================================
  Files         512      188     -324     
  Lines       22207    15378    -6829     
  Branches     1981     1059     -922     
==========================================
- Hits        13227    10322    -2905     
+ Misses       8639     4913    -3726     
+ Partials      341      143     -198     
Flag Coverage Δ
e2e-plugin-test ?
server-test 69.61% <ø> (ø)
unittest 54.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/remove/plugin branch 4 times, most recently from 54916ea to a0d06cc Compare December 26, 2023 15:29
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Copy link
Collaborator

pengx17 commented Dec 27, 2023

I think in the next step we can remove the separate vite/rollup build for @toeverything/infra and merge it into webpack

Copy link

graphite-app bot commented Dec 27, 2023

Merge activity

@graphite-app graphite-app bot merged commit 265ee81 into canary Dec 27, 2023
36 checks passed
@graphite-app graphite-app bot deleted the eyhn/remove/plugin branch December 27, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app docs Improvements or additions to documentation mod:dev mod:env mod:infra Environment related issues and discussions mod:plugin mod:plugin-cli mod:sdk plugin:copilot test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants