Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component): make component pure #5427

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 28, 2023

No description provided.

Copy link

graphite-app bot commented Dec 28, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Dec 28, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e11e827) 67.21% compared to head (9d51f95) 67.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5427   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files         190      190           
  Lines       15384    15384           
  Branches     1059     1059           
=======================================
  Hits        10341    10341           
  Misses       4900     4900           
  Partials      143      143           
Flag Coverage Δ
server-test 69.62% <ø> (ø)
unittest 54.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/refactor/component-pure branch 2 times, most recently from 8e37d22 to 4323e07 Compare December 28, 2023 09:19
@EYHN EYHN requested a review from pengx17 December 28, 2023 09:42
Copy link

graphite-app bot commented Dec 28, 2023

Merge activity

@graphite-app graphite-app bot merged commit 9d51f95 into canary Dec 28, 2023
36 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/component-pure branch December 28, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:hooks mod:workspace Related to workspace test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants