Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): long page title issue in page history #5436

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 28, 2023

CleanShot 2023-12-28 at 18.17.50@2x.png

Copy link

graphite-app bot commented Dec 28, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Dec 28, 2023

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f65c5db) 66.91% compared to head (9e092b9) 66.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5436   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files         196      196           
  Lines       15588    15588           
  Branches     1108     1108           
=======================================
  Hits        10430    10430           
  Misses       4998     4998           
  Partials      160      160           
Flag Coverage Δ
server-test 69.64% <ø> (ø)
unittest 53.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CatsJuice CatsJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it necessary to set white-space: nowrap here?

Copy link
Collaborator Author

pengx17 commented Dec 28, 2023

Seems unnecessary, but I will add it

@pengx17 pengx17 force-pushed the xp/12-28-fix_core_long_page_title_issue_in_page_history branch from 31ac878 to 97f70a1 Compare December 28, 2023 11:01
@CatsJuice
Copy link
Member

Since the test case in your screenshots is regarded as a very long word, nowrap is not necessary for this situation. Sentences composed of multiple words should be tested too.

@pengx17 pengx17 force-pushed the xp/12-28-fix_core_upgrade_page_when_previewing/reverting_page_snapshot branch from 9422e4e to 92fd2a1 Compare December 29, 2023 07:00
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_long_page_title_issue_in_page_history branch from 97f70a1 to 859a15b Compare December 29, 2023 07:00
Copy link

graphite-app bot commented Dec 29, 2023

Merge activity

@joooye34 joooye34 force-pushed the xp/12-28-fix_core_upgrade_page_when_previewing/reverting_page_snapshot branch from 92fd2a1 to f65c5db Compare December 29, 2023 07:27
@joooye34 joooye34 force-pushed the xp/12-28-fix_core_long_page_title_issue_in_page_history branch from 859a15b to 9e092b9 Compare December 29, 2023 07:27
@joooye34 joooye34 changed the base branch from xp/12-28-fix_core_upgrade_page_when_previewing/reverting_page_snapshot to canary December 29, 2023 07:35
@graphite-app graphite-app bot merged commit 9e092b9 into canary Dec 29, 2023
32 checks passed
@graphite-app graphite-app bot deleted the xp/12-28-fix_core_long_page_title_issue_in_page_history branch December 29, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants