Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): page preview ui optimize #5442

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 28, 2023

CleanShot 2023-12-28 at 23.42.44@2x.png
fix TOV-92

No animations right now.

Copy link

graphite-app bot commented Dec 28, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Dec 28, 2023

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cb62ed) 64.99% compared to head (a709624) 64.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5442   +/-   ##
=======================================
  Coverage   64.99%   64.99%           
=======================================
  Files         222      222           
  Lines       16225    16225           
  Branches     1189     1189           
=======================================
  Hits        10545    10545           
  Misses       5523     5523           
  Partials      157      157           
Flag Coverage Δ
server-test 69.73% <ø> (ø)
unittest 45.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from 32e411a to 8e9bc3d Compare December 28, 2023 16:10
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from 05e85c9 to 75be689 Compare December 28, 2023 16:11
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from 8e9bc3d to 056080f Compare December 28, 2023 16:13
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from 75be689 to 1b297ae Compare December 28, 2023 16:13
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from 056080f to ba14cc4 Compare January 2, 2024 02:22
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from 1b297ae to cf03424 Compare January 2, 2024 02:22
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from ba14cc4 to 83f8d0a Compare January 2, 2024 02:54
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch 2 times, most recently from 06d5d95 to b159481 Compare January 2, 2024 02:57
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from 83f8d0a to 63adc8d Compare January 2, 2024 05:37
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from b159481 to e42ddd8 Compare January 2, 2024 05:37
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch 2 times, most recently from 9aeb587 to 29f2dae Compare January 2, 2024 07:20
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from e42ddd8 to 1cf5f15 Compare January 2, 2024 07:20
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from 29f2dae to 9bd65f8 Compare January 2, 2024 09:48
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from 1cf5f15 to 5dd94f8 Compare January 2, 2024 09:48
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from 9bd65f8 to 03e72c4 Compare January 2, 2024 13:24
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from 5dd94f8 to 2aa9f19 Compare January 2, 2024 13:24
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from 03e72c4 to b36834b Compare January 2, 2024 14:48
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from 2aa9f19 to 7ce4a44 Compare January 2, 2024 14:48
@pengx17 pengx17 force-pushed the xp/12-28-fix_core_add_free_plan_prompt branch from b36834b to 8dc3e3d Compare January 3, 2024 01:50
@pengx17 pengx17 changed the base branch from xp/12-28-fix_core_add_free_plan_prompt to canary January 3, 2024 02:00
@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch 2 times, most recently from edfea64 to 6b20cac Compare January 3, 2024 03:21
Copy link

graphite-app bot commented Jan 3, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/12-28-feat_core_page_preview_ui_optimize branch from 6b20cac to a709624 Compare January 3, 2024 03:30
@graphite-app graphite-app bot merged commit a709624 into canary Jan 3, 2024
36 checks passed
@graphite-app graphite-app bot deleted the xp/12-28-feat_core_page_preview_ui_optimize branch January 3, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants