Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace level feature apis #5503

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

darkskygit
Copy link
Member

@darkskygit darkskygit commented Jan 3, 2024

fix TOV-279

Copy link

graphite-app bot commented Jan 3, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

darkskygit commented Jan 3, 2024

@github-actions github-actions bot added app:server test Related to test cases labels Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 132 lines in your changes are missing coverage. Please review.

Comparison is base (04ca554) 41.62% compared to head (f6ec786) 65.26%.

Files Patch % Lines
.../server/src/data/migrations/utils/user-features.ts 39.00% 61 Missing ⚠️
...ges/backend/server/src/modules/users/management.ts 58.24% 38 Missing ⚠️
...ackend/server/src/modules/workspaces/management.ts 65.51% 29 Missing and 1 partial ⚠️
.../backend/server/src/modules/features/management.ts 76.92% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5503       +/-   ##
===========================================
+ Coverage   41.62%   65.26%   +23.63%     
===========================================
  Files         206      239       +33     
  Lines       13513    17233     +3720     
  Branches      711     1244      +533     
===========================================
+ Hits         5625    11247     +5622     
+ Misses       7754     5827     -1927     
- Partials      134      159       +25     
Flag Coverage Δ
server-test 69.72% <60.36%> (+29.40%) ⬆️
unittest 45.88% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-test branch from a36f509 to 29a6768 Compare January 3, 2024 13:42
@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-apis branch from 817abca to e2d3f76 Compare January 3, 2024 13:42
@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-test branch from 29a6768 to 6255795 Compare January 3, 2024 13:56
@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-apis branch from e2d3f76 to 74a9ac6 Compare January 3, 2024 13:56
@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-test branch from 6255795 to e5ea598 Compare January 3, 2024 14:02
@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-apis branch 2 times, most recently from 4a1d433 to 459acae Compare January 3, 2024 15:12
Copy link

graphite-app bot commented Jan 4, 2024

Merge activity

@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-test branch from 80d7884 to 04ca554 Compare January 5, 2024 04:14
@darkskygit darkskygit force-pushed the darksky/workspace-level_feature-apis branch from 56f2e70 to f6ec786 Compare January 5, 2024 04:15
@Brooooooklyn Brooooooklyn changed the base branch from darksky/workspace-level_feature-test to canary January 5, 2024 07:13
@graphite-app graphite-app bot merged commit f6ec786 into canary Jan 5, 2024
32 checks passed
@graphite-app graphite-app bot deleted the darksky/workspace-level_feature-apis branch January 5, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants