-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shared page filter to all pages #5540
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #5540 +/- ##
==========================================
- Coverage 64.34% 64.34% -0.01%
==========================================
Files 360 360
Lines 19949 19951 +2
Branches 1702 1702
==========================================
Hits 12837 12837
- Misses 6892 6894 +2
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
43a775e
to
de028c2
Compare
7f15702
to
03ca8e8
Compare
1aa14e3
to
e5dd93d
Compare
e5dd93d
to
1c2bd0d
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3986add. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
d00bc9a
to
dd3f4df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern is that usePublicPages will make it unavailable offline.
But don't worry, I will fix it in the future.
Resolves #5102