Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shared page filter to all pages #5540

Merged
merged 8 commits into from
Feb 23, 2024
Merged

feat: add shared page filter to all pages #5540

merged 8 commits into from
Feb 23, 2024

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Jan 8, 2024

Resolves #5102

@github-actions github-actions bot added mod:i18n Related to i18n mod:component test Related to test cases app:core labels Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.34%. Comparing base (3f7f78c) to head (3986add).
Report is 1 commits behind head on canary.

Files Patch % Lines
...src/components/page-list/use-collection-manager.ts 25.00% 3 Missing ⚠️
...onents/page-list/filter/filter-tag-translation.tsx 0.00% 1 Missing ⚠️
...e/src/components/page-list/filter/shared-types.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5540      +/-   ##
==========================================
- Coverage   64.34%   64.34%   -0.01%     
==========================================
  Files         360      360              
  Lines       19949    19951       +2     
  Branches     1702     1702              
==========================================
  Hits        12837    12837              
- Misses       6892     6894       +2     
  Partials      220      220              
Flag Coverage Δ
server-test 71.23% <ø> (ø)
unittest 45.12% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lawvs lawvs force-pushed the feat/filter-public branch 3 times, most recently from 43a775e to de028c2 Compare January 13, 2024 15:43
@lawvs lawvs changed the title feat: filter shared pages feat: add shared page filter to all pages Jan 15, 2024
@lawvs lawvs force-pushed the feat/filter-public branch 2 times, most recently from 7f15702 to 03ca8e8 Compare January 21, 2024 18:05
@lawvs lawvs force-pushed the feat/filter-public branch 4 times, most recently from 1aa14e3 to e5dd93d Compare January 31, 2024 07:35
Copy link

nx-cloud bot commented Feb 8, 2024

@EYHN EYHN self-requested a review February 23, 2024 07:58
Copy link
Member

@EYHN EYHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern is that usePublicPages will make it unavailable offline.

But don't worry, I will fix it in the future.

@EYHN EYHN merged commit 228b0d7 into canary Feb 23, 2024
40 of 42 checks passed
@EYHN EYHN deleted the feat/filter-public branch February 23, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:i18n Related to i18n test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add new feature to filter shared pages
2 participants