Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: filter out edgeless content from page preview #5607

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Jan 16, 2024

The surface block is a special block that contains edgeless data, its information is not helpful for page preview

Screenshot 2024-01-16 at 22 01 02

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.33%. Comparing base (228b0d7) to head (1d30526).
Report is 1 commits behind head on canary.

Files Patch % Lines
...mponents/page-list/use-block-suite-page-preview.ts 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5607      +/-   ##
==========================================
- Coverage   64.34%   64.33%   -0.01%     
==========================================
  Files         360      360              
  Lines       19951    19954       +3     
  Branches     1702     1703       +1     
==========================================
  Hits        12837    12837              
- Misses       6894     6896       +2     
- Partials      220      221       +1     
Flag Coverage Δ
server-test 71.23% <ø> (ø)
unittest 45.10% <16.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lawvs lawvs force-pushed the chore/filter-out-frame-from-preview branch from 90a44b2 to ea610cf Compare January 21, 2024 18:04
@lawvs lawvs force-pushed the chore/filter-out-frame-from-preview branch 2 times, most recently from bc255ee to 3c5ac86 Compare January 31, 2024 06:59
@lawvs lawvs force-pushed the chore/filter-out-frame-from-preview branch from 3c5ac86 to a7f10cf Compare February 8, 2024 15:42
Copy link

nx-cloud bot commented Feb 8, 2024

@lawvs lawvs force-pushed the chore/filter-out-frame-from-preview branch from a7f10cf to a5a0f2a Compare February 22, 2024 16:56
@EYHN EYHN enabled auto-merge (squash) February 23, 2024 08:09
@EYHN EYHN merged commit 9692a12 into canary Feb 23, 2024
39 of 41 checks passed
@EYHN EYHN deleted the chore/filter-out-frame-from-preview branch February 23, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants