feat: sync client versioning #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## canary #5645 +/- ##
==========================================
+ Coverage 65.02% 65.14% +0.12%
==========================================
Files 345 345
Lines 19597 19536 -61
Branches 1652 1649 -3
==========================================
- Hits 12742 12727 -15
+ Misses 6637 6589 -48
- Partials 218 220 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
darkskygit
force-pushed
the
darksky/sync-client-versioning
branch
4 times, most recently
from
0b40579
to
1220469
Compare
darkskygit
force-pushed
the
darksky/sync-client-versioning
branch
2 times, most recently
from
189075e
to
6aa33fc
Compare
github-actions
bot
added
the
mod:infra
darkskygit
force-pushed
the
darksky/sync-client-versioning
branch
2 times, most recently
from
ca97d71
to
505b10b
Compare
darkskygit
force-pushed
the
darksky/sync-client-versioning
branch
from
48f272d
to
5b19927
Compare
JimmFly
approved these changes
Feb 2, 2024
darkskygit
force-pushed
the
darksky/sync-client-versioning
branch
from
5b19927
to
7b6b83b
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 25e8a2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Merge activity
|
after this pr, server will only accept client that have some major version the client version <0.12 will be rejected by the server, >= 0.12 can receive outdated messages and notify users
darkskygit
force-pushed
the
darksky/sync-client-versioning
branch
from
905bc11
to
25e8a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after this pr, server will only accept client that have some major version
the client version <0.12 will be rejected by the server, >= 0.12 can receive outdated messages and notify users
fix TOV-216