Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): set createDate to journal's date when journal created #5701

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jan 25, 2024

Copy link

graphite-app bot commented Jan 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (329fc19) 64.49% compared to head (e4b1c87) 64.48%.

Files Patch % Lines
packages/frontend/core/src/hooks/use-journal.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5701      +/-   ##
==========================================
- Coverage   64.49%   64.48%   -0.01%     
==========================================
  Files         339      339              
  Lines       19232    19233       +1     
  Branches     1630     1630              
==========================================
  Hits        12403    12403              
- Misses       6613     6614       +1     
  Partials      216      216              
Flag Coverage Δ
server-test 70.78% <ø> (ø)
unittest 46.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/012-journal-fix/tov-467 branch from 1c67d1c to e4b1c87 Compare January 30, 2024 08:43
@joooye34 joooye34 merged commit 5f3c04b into canary Jan 30, 2024
38 of 40 checks passed
@joooye34 joooye34 deleted the catsjuice/012-journal-fix/tov-467 branch January 30, 2024 15:11
saranshisatgit pushed a commit to Meta-Root-Zones/AFFiNE that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants