Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): ignore empty journal for global useBlockSuitePageMeta hook #5715

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

CatsJuice
Copy link
Member

Copy link

graphite-app bot commented Jan 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

CatsJuice commented Jan 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0fff558) 64.52% compared to head (390fb90) 64.43%.

Files Patch % Lines
...nd/core/src/hooks/use-all-block-suite-page-meta.ts 90.90% 1 Missing ⚠️
...ontend/core/src/hooks/use-block-suite-page-meta.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5715      +/-   ##
==========================================
- Coverage   64.52%   64.43%   -0.10%     
==========================================
  Files         358      359       +1     
  Lines       19911    19916       +5     
  Branches     1698     1697       -1     
==========================================
- Hits        12848    12833      -15     
- Misses       6844     6863      +19     
- Partials      219      220       +1     
Flag Coverage Δ
server-test 71.23% <ø> (-0.13%) ⬇️
unittest 45.35% <88.23%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/012-journal-fix/tov-494 branch from a9786ee to c6fc751 Compare January 26, 2024 06:53
@github-actions github-actions bot added the test Related to test cases label Jan 26, 2024
Copy link

graphite-app bot commented Jan 30, 2024

Merge activity

Copy link

nx-cloud bot commented Feb 5, 2024

@Brooooooklyn Brooooooklyn force-pushed the catsjuice/012-journal-fix/tov-494 branch from f5ae1a2 to 390fb90 Compare February 22, 2024 08:09
@graphite-app graphite-app bot merged commit 390fb90 into canary Feb 22, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the catsjuice/012-journal-fix/tov-494 branch February 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants