Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cards overlapping issue #5727

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

Coder-Arsil
Copy link
Contributor

@Coder-Arsil Coder-Arsil commented Jan 27, 2024

What this pr does?

  • This PR fixed the card overlapping issue at onboarding page.
  • You can compare these 2 screen shots

fixed: #5726

Before

affine-ss

Now After solved

fine

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa3baa6) 65.24% compared to head (7d3c27d) 46.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5727       +/-   ##
===========================================
- Coverage   65.24%   46.78%   -18.46%     
===========================================
  Files         348      215      -133     
  Lines       19670     4972    -14698     
  Branches     1661      886      -775     
===========================================
- Hits        12833     2326    -10507     
+ Misses       6616     2456     -4160     
+ Partials      221      190       -31     
Flag Coverage Δ
server-test ?
unittest 46.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hwangdev97
Copy link
Member

LGTM ❤️, thanks.

Copy link
Member

@EYHN EYHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

nx-cloud bot commented Feb 20, 2024

@Brooooooklyn Brooooooklyn merged commit 1eb317d into toeverything:canary Feb 20, 2024
32 of 34 checks passed
Brooooooklyn pushed a commit that referenced this pull request Feb 21, 2024
Co-authored-by: EYHN <cneyhn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Card and Heading is overlapped ​
6 participants