fix(core): replace most --affine with cssVar #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5728 +/- ##
==========================================
+ Coverage 64.58% 64.67% +0.09%
==========================================
Files 342 342
Lines 19401 19401
Branches 1649 1650 +1
==========================================
+ Hits 12530 12548 +18
+ Misses 6655 6637 -18
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pengx17
force-pushed
the
xp/01-27-fix_core_replace_most_--affine_with_cssVar
branch
5 times, most recently
from
9b6697e
to
b8832b6
Compare
CatsJuice
approved these changes
Jan 29, 2024
pengx17
force-pushed
the
xp/01-27-fix_core_replace_most_--affine_with_cssVar
branch
from
b8832b6
to
4b8f261
Compare
Merge activity
|
using a [babel plugin](https://gist.github.com/pengx17/49e24ae8a5a609bdaff122ee8c679d1c) to transform all var(--affine-xxx) to cssVar Some issues: - tried ast-grep but it seems to be not easy to add imports conditionally - current work does not work well with ts with types because babel will strip them out
Brooooooklyn
force-pushed
the
xp/01-27-fix_core_replace_most_--affine_with_cssVar
branch
from
4b8f261
to
7d951a9
Compare
graphite-app
bot
deleted the
xp/01-27-fix_core_replace_most_--affine_with_cssVar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using a babel plugin to transform all var(--affine-xxx) to cssVar
Some issues: