Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): editor container grow to full height #5743

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 30, 2024

No description provided.

Copy link

graphite-app bot commented Jan 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Jan 30, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a120eb9) 64.69% compared to head (58ea2fb) 45.32%.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5743       +/-   ##
===========================================
- Coverage   64.69%   45.32%   -19.38%     
===========================================
  Files         358      225      -133     
  Lines       19924     5225    -14699     
  Branches     1699      924      -775     
===========================================
- Hits        12889     2368    -10521     
+ Misses       6816     2669     -4147     
+ Partials      219      188       -31     
Flag Coverage Δ
server-test ?
unittest 45.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/01-30-fix_core_editor_container_grow_to_full_height branch 2 times, most recently from f1dfefe to 4894844 Compare February 1, 2024 14:46
@pengx17 pengx17 force-pushed the xp/01-30-fix_core_editor_container_grow_to_full_height branch from 4894844 to 98452d0 Compare February 22, 2024 03:43
Copy link

nx-cloud bot commented Feb 22, 2024

Copy link

graphite-app bot commented Feb 22, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the xp/01-30-fix_core_editor_container_grow_to_full_height branch from 98452d0 to 58ea2fb Compare February 22, 2024 06:20
@graphite-app graphite-app bot merged commit 58ea2fb into canary Feb 22, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the xp/01-30-fix_core_editor_container_grow_to_full_height branch February 22, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants