refactor(core): use custom scrollbar for editor and adjust shared page style #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5752 +/- ##
=======================================
Coverage 64.31% 64.31%
=======================================
Files 360 360
Lines 19969 19969
Branches 1705 1705
=======================================
Hits 12844 12844
Misses 6904 6904
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
from
9d63466
to
b1e77d4
Compare
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
3 times, most recently
from
ca70aaf
to
182b563
Compare
JimmFly
changed the title
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
from
182b563
to
cf86705
Compare
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
2 times, most recently
from
7b48bed
to
5bec7da
Compare
CatsJuice
reviewed
Feb 2, 2024
packages/frontend/core/src/components/cloud/share-header-right-item/authenticated-item.tsx
Show resolved
Hide resolved
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
from
5bec7da
to
fb01105
Compare
CatsJuice
approved these changes
Feb 19, 2024
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
from
fb01105
to
b30ae86
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0be62d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
3 times, most recently
from
e3741c3
to
2e3a658
Compare
Brooooooklyn
approved these changes
Feb 26, 2024
Merge activity
|
JimmFly
force-pushed
the
jimmfly/0130/share-page
branch
from
2e3a658
to
bea3009
Compare
Brooooooklyn
force-pushed
the
jimmfly/0130/share-page
branch
from
bea3009
to
0be62d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close TOV-481