Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore case for email #5754

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

darkskygit
Copy link
Member

@darkskygit darkskygit commented Jan 31, 2024

fix #5738

Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (349f7c3) 64.45% compared to head (1db8019) 64.54%.

Files Patch % Lines
packages/backend/server/src/core/auth/service.ts 65.38% 9 Missing ⚠️
.../backend/server/src/core/auth/next-auth-options.ts 0.00% 4 Missing ⚠️
...ckend/server/src/core/auth/next-auth.controller.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5754      +/-   ##
==========================================
+ Coverage   64.45%   64.54%   +0.08%     
==========================================
  Files         343      343              
  Lines       19414    19442      +28     
  Branches     1654     1655       +1     
==========================================
+ Hits        12513    12548      +35     
+ Misses       6685     6678       -7     
  Partials      216      216              
Flag Coverage Δ
server-test 70.81% <63.04%> (+0.10%) ⬆️
unittest 46.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 31, 2024

Merge activity

darkskygit added a commit that referenced this pull request Jan 31, 2024
@darkskygit darkskygit force-pushed the darksky/email-case-insensitive branch from 3f4bffd to 63672c0 Compare January 31, 2024 14:38
@darkskygit darkskygit force-pushed the darksky/email-case-insensitive branch from 63672c0 to 1db8019 Compare February 1, 2024 05:05
@graphite-app graphite-app bot merged commit 1db8019 into canary Feb 1, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the darksky/email-case-insensitive branch February 1, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

make account register case insensitive
2 participants