Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace ambiguous "page" with "doc" #5761

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Feb 1, 2024

close TOV-532

Copy link

graphite-app bot commented Feb 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

JimmFly commented Feb 1, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added mod:i18n Related to i18n app:electron Related to electron app app:core labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85be45a) 64.50% compared to head (c353b0d) 45.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5761       +/-   ##
===========================================
- Coverage   64.50%   45.36%   -19.15%     
===========================================
  Files         360      227      -133     
  Lines       19958     5260    -14698     
  Branches     1702      928      -774     
===========================================
- Hits        12874     2386    -10488     
+ Misses       6865     2686     -4179     
+ Partials      219      188       -31     
Flag Coverage Δ
server-test ?
unittest 45.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Feb 1, 2024
@JimmFly JimmFly requested a review from joooye34 February 1, 2024 03:56
@JimmFly JimmFly force-pushed the jimmfly/0201/page-to-doc branch 3 times, most recently from a6d5ef2 to 56c7753 Compare February 2, 2024 08:02
Copy link

nx-cloud bot commented Feb 20, 2024

@JimmFly JimmFly force-pushed the jimmfly/0201/page-to-doc branch 2 times, most recently from fce7a3a to fa8c3cd Compare February 21, 2024 05:01
Copy link

graphite-app bot commented Feb 21, 2024

Merge activity

@graphite-app graphite-app bot merged commit c353b0d into canary Feb 21, 2024
43 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0201/page-to-doc branch February 21, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:i18n Related to i18n test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants