Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): fix sync stuck #5762

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix(workspace): fix sync stuck #5762

merged 1 commit into from
Feb 1, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Feb 1, 2024

  • remove MultipleBatchSyncSender
  • add timeout (30 seconds) on socket.emit

Copy link

graphite-app bot commented Feb 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Feb 1, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@EYHN EYHN changed the title fix(workspace-impl): fix sync stuck fix(workspace): fix sync stuck Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (aa33bf6) 64.44% compared to head (799fa9c) 64.67%.

Files Patch % Lines
packages/frontend/workspace-impl/src/cloud/sync.ts 1.92% 51 Missing ⚠️
...ges/frontend/workspace-impl/src/cloud/awareness.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5762      +/-   ##
==========================================
+ Coverage   64.44%   64.67%   +0.22%     
==========================================
  Files         343      342       -1     
  Lines       19442    19401      -41     
  Branches     1654     1650       -4     
==========================================
+ Hits        12530    12548      +18     
+ Misses       6696     6637      -59     
  Partials      216      216              
Flag Coverage Δ
server-test 70.81% <ø> (+0.12%) ⬆️
unittest 46.55% <1.81%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 1, 2024

Merge activity

* remove MultipleBatchSyncSender
* add timeout (30 seconds) on socket.emit
@graphite-app graphite-app bot merged commit 799fa9c into canary Feb 1, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix-sync branch February 1, 2024 07:06
EYHN added a commit that referenced this pull request Feb 1, 2024
* remove MultipleBatchSyncSender
* add timeout (30 seconds) on socket.emit
EYHN added a commit that referenced this pull request Feb 1, 2024
* remove MultipleBatchSyncSender
* add timeout (30 seconds) on socket.emit
joooye34 pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants