-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workspace): fix sync stuck #5762
Conversation
EYHN
commented
Feb 1, 2024
•
edited
edited
- remove MultipleBatchSyncSender
- add timeout (30 seconds) on socket.emit
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## canary #5762 +/- ##
==========================================
+ Coverage 64.44% 64.67% +0.22%
==========================================
Files 343 342 -1
Lines 19442 19401 -41
Branches 1654 1650 -4
==========================================
+ Hits 12530 12548 +18
+ Misses 6696 6637 -59
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merge activity
|
* remove MultipleBatchSyncSender * add timeout (30 seconds) on socket.emit
5ea28c9
to
799fa9c
Compare
* remove MultipleBatchSyncSender * add timeout (30 seconds) on socket.emit
* remove MultipleBatchSyncSender * add timeout (30 seconds) on socket.emit