Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): typecheck after jotai upgraded #5779

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

Brooooooklyn
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Feb 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

Brooooooklyn commented Feb 1, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45b5800) 64.66% compared to head (8f4b4e2) 46.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5779       +/-   ##
===========================================
- Coverage   64.66%   46.55%   -18.11%     
===========================================
  Files         342      214      -128     
  Lines       19373     4912    -14461     
  Branches     1645      875      -770     
===========================================
- Hits        12528     2287    -10241     
+ Misses       6628     2438     -4190     
+ Partials      217      187       -30     
Flag Coverage Δ
server-test ?
unittest 46.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 1, 2024

Merge activity

@graphite-app graphite-app bot merged commit 8f4b4e2 into canary Feb 1, 2024
37 of 41 checks passed
@graphite-app graphite-app bot deleted the fix/typecheck branch February 1, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants