feat(core): add loading to quick search modal #5785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
JimmFly
force-pushed
the
jimmfly/0202/loading
branch
from
acd180f
to
7df36cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5785 +/- ##
===========================================
- Coverage 65.23% 46.85% -18.39%
===========================================
Files 350 217 -133
Lines 19690 4992 -14698
Branches 1668 893 -775
===========================================
- Hits 12845 2339 -10506
+ Misses 6624 2463 -4161
+ Partials 221 190 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pengx17
approved these changes
Feb 2, 2024
JimmFly
force-pushed
the
jimmfly/0202/loading
branch
from
7df36cd
to
dc931c5
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 876b853. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Brooooooklyn
approved these changes
Feb 20, 2024
Merge activity
|
close AFF-285 add `useSyncEngineStatus` hooks add loading style <img width="977" alt="test1" src="https://github.com/toeverything/AFFiNE/assets/102217452/e8bf6714-e42b-4adf-a279-341ef5f5cfc0">
Brooooooklyn
force-pushed
the
jimmfly/0202/loading
branch
from
dc931c5
to
876b853
Compare
Brooooooklyn
pushed a commit
that referenced
this pull request
Feb 21, 2024
close AFF-285 add `useSyncEngineStatus` hooks add loading style <img width="977" alt="test1" src="https://github.com/toeverything/AFFiNE/assets/102217452/e8bf6714-e42b-4adf-a279-341ef5f5cfc0">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close AFF-285
add
useSyncEngineStatushooksadd loading style