Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip sync when offline #5786

Merged
merged 1 commit into from
Feb 19, 2024
Merged

chore: skip sync when offline #5786

merged 1 commit into from
Feb 19, 2024

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Feb 2, 2024

This pull request adds the functionality to skip the sync workspace when the user is offline.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e3ffec) 65.19% compared to head (6a2721d) 65.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5786   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files         347      347           
  Lines       19624    19624           
  Branches     1649     1649           
=======================================
  Hits        12793    12793           
  Misses       6611     6611           
  Partials      220      220           
Flag Coverage Δ
server-test 71.49% <ø> (ø)
unittest 46.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

nx-cloud bot commented Feb 8, 2024

@EYHN EYHN merged commit 1ceaf87 into canary Feb 19, 2024
37 of 41 checks passed
@EYHN EYHN deleted the fix/skip-sync-when-offline branch February 19, 2024 02:22
Brooooooklyn pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants