Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): apply env overrides after all config merged #5795

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Feb 4, 2024

No description provided.

Copy link

graphite-app bot commented Feb 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

forehalo commented Feb 4, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (899528d) 65.00% compared to head (d9c2dc8) 64.92%.

Files Patch % Lines
...s/backend/server/src/core/workspaces/controller.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5795      +/-   ##
==========================================
- Coverage   65.00%   64.92%   -0.09%     
==========================================
  Files         345      345              
  Lines       19587    19597      +10     
  Branches     1652     1651       -1     
==========================================
- Hits        12733    12723      -10     
- Misses       6637     6656      +19     
- Partials      217      218       +1     
Flag Coverage Δ
server-test 71.06% <94.73%> (-0.11%) ⬇️
unittest 46.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

perfsee bot commented Feb 4, 2024

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     master …nfig-override                 +/- ##
===================================================================
  Bundle                    ?        8.73 MB                       
  Initial JS                ?        4.78 MB                       
  Initial CSS               ?        80.3 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
  Assets                    ?            137                       
  Chunks                    ?            135                       
  Packages                  ?            282                       
< Duplicates                0             10                 +10   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Split assets into smaller pieces                                 
! Avoid large JavaScript libraries with smaller alternatives       
! Separate mixed content assets files                              
! Uncontrolled libraries used in bundle result                     
! Improve page load speed with `preconnect` or `dns-prefetch`      
! Avoid cache wasting                                              

Copy link

graphite-app bot commented Feb 4, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants