Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): separate s3 & r2 storage to plugin #5805

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Feb 5, 2024

No description provided.

Copy link

graphite-app bot commented Feb 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

forehalo commented Feb 5, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

nx-cloud bot commented Feb 5, 2024

@forehalo forehalo force-pushed the 61/storage-plugin branch 3 times, most recently from 19d8e09 to 7a6bcf5 Compare February 5, 2024 10:31
Copy link

graphite-app bot commented Feb 5, 2024

Merge activity

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (25e8a2a) 65.15% compared to head (296d47f) 65.18%.

Files Patch % Lines
...ckages/backend/server/src/plugins/storage/index.ts 75.00% 10 Missing ⚠️
...server/src/fundamentals/storage/providers/index.ts 79.31% 5 Missing and 1 partial ⚠️
.../backend/server/src/fundamentals/storage/native.ts 83.33% 5 Missing ⚠️
packages/backend/server/src/config/affine.self.ts 0.00% 4 Missing ⚠️
...s/backend/server/src/fundamentals/storage/index.ts 83.33% 3 Missing ⚠️
...backend/server/src/core/storage/wrappers/avatar.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5805      +/-   ##
==========================================
+ Coverage   65.15%   65.18%   +0.03%     
==========================================
  Files         345      347       +2     
  Lines       19536    19626      +90     
  Branches     1649     1648       -1     
==========================================
+ Hits        12728    12794      +66     
- Misses       6588     6612      +24     
  Partials      220      220              
Flag Coverage Δ
server-test 71.49% <83.88%> (+0.01%) ⬆️
unittest 46.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graphite-app graphite-app bot merged commit 296d47f into canary Feb 6, 2024
38 of 42 checks passed
@graphite-app graphite-app bot deleted the 61/storage-plugin branch February 6, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants