fix(electron): linux login issues #5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 20f7473. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
pengx17
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5821 +/- ##
=======================================
Coverage 65.22% 65.22%
=======================================
Files 348 348
Lines 19675 19675
Branches 1657 1657
=======================================
Hits 12833 12833
Misses 6621 6621
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pengx17
force-pushed
the
02-13-fix_electron_Linux_login_issues
branch
from
115b8c0
to
89ee392
Compare
EYHN
approved these changes
Feb 19, 2024
Merge activity
|
Looks like there are some issues using `@reforged/maker-appimage`: - deep link not working properly (cannot login) - cannot be installed via AppImageLauncher, which is required to enable deep link on linux I forked saleae/electron-forge-maker-appimage into https://github.com/toeverything/electron-forge-maker-appimage to fix these issues See changes: https://github.com/saleae/electron-forge-maker-appimage/compare/master...toeverything:electron-forge-maker-appimage:master?w=1 To enable login on Linux, the app must be installed via AppImageLauncher.  fix #4978 fix #4466
Brooooooklyn
force-pushed
the
02-13-fix_electron_Linux_login_issues
branch
from
89ee392
to
20f7473
Compare
Brooooooklyn
pushed a commit
that referenced
this pull request
Feb 21, 2024
Looks like there are some issues using `@reforged/maker-appimage`: - deep link not working properly (cannot login) - cannot be installed via AppImageLauncher, which is required to enable deep link on linux I forked saleae/electron-forge-maker-appimage into https://github.com/toeverything/electron-forge-maker-appimage to fix these issues See changes: https://github.com/saleae/electron-forge-maker-appimage/compare/master...toeverything:electron-forge-maker-appimage:master?w=1 To enable login on Linux, the app must be installed via AppImageLauncher.  fix #4978 fix #4466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there are some issues using
@reforged/maker-appimage:I forked saleae/electron-forge-maker-appimage into https://github.com/toeverything/electron-forge-maker-appimage to fix these issues
See changes: https://github.com/saleae/electron-forge-maker-appimage/compare/master...toeverything:electron-forge-maker-appimage:master?w=1
To enable login on Linux, the app must be installed via AppImageLauncher.
fix #4978
fix #4466