Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): disable sidebar user select #5862

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Feb 22, 2024

close #5846

Copy link

graphite-app bot commented Feb 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Feb 22, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@EYHN EYHN marked this pull request as ready for review February 22, 2024 03:12
Copy link

nx-cloud bot commented Feb 22, 2024

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d421a3) 64.52% compared to head (0fff558) 64.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5862      +/-   ##
==========================================
- Coverage   64.52%   64.52%   -0.01%     
==========================================
  Files         358      358              
  Lines       19911    19911              
  Branches     1698     1698              
==========================================
- Hits        12848    12847       -1     
- Misses       6844     6845       +1     
  Partials      219      219              
Flag Coverage Δ
server-test 71.35% <ø> (ø)
unittest 45.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 22, 2024

Merge activity

@graphite-app graphite-app bot merged commit 0fff558 into canary Feb 22, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/sidebar-select branch February 22, 2024 08:08
Brooooooklyn pushed a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

BUG: Sidebar texts can be selected.​
2 participants