fix(electron): add back bundle test for appimage #5876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0bbecec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5876 +/- ##
==========================================
+ Coverage 64.35% 64.44% +0.09%
==========================================
Files 360 360
Lines 19946 19946
Branches 1701 1702 +1
==========================================
+ Hits 12836 12854 +18
+ Misses 6890 6872 -18
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Brooooooklyn
approved these changes
Feb 23, 2024
Merge activity
|
In an attempt to fix AppImage build test, I incorrectly removed the script. This PR add it back.
Brooooooklyn
force-pushed
the
02-22-add-back-appimage-test
branch
from
41c6d23
to
8b1d721
Compare
Brooooooklyn
force-pushed
the
add-back-app-image-test
branch
from
4677d05
to
0bbecec
Compare
Brooooooklyn
changed the base branch from
02-22-add-back-appimage-test
to
canary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix AppImage build test, I incorrectly removed the script.
This PR add it back.