Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix image preview modal story #5879

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 23, 2024

No description provided.

Copy link

graphite-app bot commented Feb 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 23, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the test Related to test cases label Feb 23, 2024
Copy link

nx-cloud bot commented Feb 23, 2024

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.44%. Comparing base (0bbecec) to head (c22216c).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5879   +/-   ##
=======================================
  Coverage   64.44%   64.44%           
=======================================
  Files         360      360           
  Lines       19946    19946           
  Branches     1702     1702           
=======================================
  Hits        12854    12854           
  Misses       6872     6872           
  Partials      220      220           
Flag Coverage Δ
server-test 71.35% <ø> (ø)
unittest 45.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 requested a review from EYHN February 23, 2024 03:40
Copy link

graphite-app bot commented Feb 23, 2024

Merge activity

@pengx17 pengx17 force-pushed the 02-23-fix_fix_image_preview_modal_story branch from bfe8dfc to c22216c Compare February 23, 2024 06:07
@graphite-app graphite-app bot merged commit c22216c into canary Feb 23, 2024
39 of 42 checks passed
@graphite-app graphite-app bot deleted the 02-23-fix_fix_image_preview_modal_story branch February 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants