Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add shortcut for openning settings #5883

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 23, 2024

fix #5881

Copy link

graphite-app bot commented Feb 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 23, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

nx-cloud bot commented Feb 23, 2024

@pengx17 pengx17 marked this pull request as ready for review February 23, 2024 06:08
@pengx17 pengx17 requested a review from JimmFly February 23, 2024 06:09
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (bef7202) to head (7ec3f7a).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5883   +/-   ##
=======================================
  Coverage   64.34%   64.35%           
=======================================
  Files         360      360           
  Lines       19949    19949           
  Branches     1702     1702           
=======================================
+ Hits        12837    12838    +1     
  Misses       6892     6892           
+ Partials      220      219    -1     
Flag Coverage Δ
server-test 71.23% <ø> (+<0.01%) ⬆️
unittest 45.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 23, 2024

Merge activity

@pengx17 pengx17 force-pushed the 02-23-fix_keyboard_shortcut_style_in_cmdk branch from a318ac6 to bef7202 Compare February 23, 2024 06:30
@pengx17 pengx17 force-pushed the 02-23-feat_core_add_shortcut_for_openning_settings branch from 1812cf3 to 7ec3f7a Compare February 23, 2024 06:30
@pengx17 pengx17 changed the base branch from 02-23-fix_keyboard_shortcut_style_in_cmdk to canary February 23, 2024 06:40
@graphite-app graphite-app bot merged commit 7ec3f7a into canary Feb 23, 2024
34 checks passed
@graphite-app graphite-app bot deleted the 02-23-feat_core_add_shortcut_for_openning_settings branch February 23, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feature Request: Add ⌘ + ',' shortcut and Menu item for open Settings panel.
3 participants