Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page info ui issue on journal page #5887

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 23, 2024

No description provided.

Copy link

graphite-app bot commented Feb 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 23, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added test Related to test cases app:core labels Feb 23, 2024
@pengx17 pengx17 requested review from Brooooooklyn and CatsJuice and removed request for Brooooooklyn February 23, 2024 07:46
@pengx17 pengx17 marked this pull request as ready for review February 23, 2024 07:46
Copy link

nx-cloud bot commented Feb 23, 2024

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.34%. Comparing base (3f7f78c) to head (745110c).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5887   +/-   ##
=======================================
  Coverage   64.34%   64.34%           
=======================================
  Files         360      360           
  Lines       19949    19949           
  Branches     1702     1702           
=======================================
  Hits        12837    12837           
  Misses       6892     6892           
  Partials      220      220           
Flag Coverage Δ
server-test 71.23% <ø> (ø)
unittest 45.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 23, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 02-23-fix_page_info_ui_issue_on_journal_page branch from 17a5bc9 to 745110c Compare February 23, 2024 07:55
@graphite-app graphite-app bot merged commit 745110c into canary Feb 23, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the 02-23-fix_page_info_ui_issue_on_journal_page branch February 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants