Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): handle unexpected error from storage provider #5888

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

darkskygit
Copy link
Member

@darkskygit darkskygit commented Feb 23, 2024

image

handle unexpected error in workspace usage calc

Copy link

graphite-app bot commented Feb 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

nx-cloud bot commented Feb 23, 2024

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 64.41%. Comparing base (f003fa0) to head (d9fee81).

Files Patch % Lines
packages/backend/server/src/core/quota/storage.ts 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5888      +/-   ##
==========================================
- Coverage   64.42%   64.41%   -0.02%     
==========================================
  Files         360      360              
  Lines       19954    19967      +13     
  Branches     1704     1706       +2     
==========================================
+ Hits        12856    12861       +5     
- Misses       6877     6885       +8     
  Partials      221      221              
Flag Coverage Δ
server-test 71.33% <56.25%> (-0.03%) ⬇️
unittest 45.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn changed the title feat: handle unexpected error from storage provider fix(server): handle unexpected error from storage provider Feb 23, 2024
Copy link

graphite-app bot commented Feb 23, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the darksky/catch-storage-provider-error branch from 05190ea to d9fee81 Compare February 23, 2024 08:53
@graphite-app graphite-app bot merged commit d9fee81 into canary Feb 23, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the darksky/catch-storage-provider-error branch February 23, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants