Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page properties flaky tests #5893

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 23, 2024

No description provided.

Copy link

graphite-app bot commented Feb 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 23, 2024

@github-actions github-actions bot added the test Related to test cases label Feb 23, 2024
@pengx17 pengx17 mentioned this pull request Feb 23, 2024
@pengx17 pengx17 requested a review from JimmFly February 23, 2024 09:32
@pengx17 pengx17 marked this pull request as ready for review February 23, 2024 09:32
Copy link

nx-cloud bot commented Feb 23, 2024

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.31%. Comparing base (9e7406e) to head (c16e4d4).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5893      +/-   ##
==========================================
- Coverage   64.41%   64.31%   -0.10%     
==========================================
  Files         360      360              
  Lines       19969    19969              
  Branches     1706     1705       -1     
==========================================
- Hits        12863    12844      -19     
- Misses       6885     6904      +19     
  Partials      221      221              
Flag Coverage Δ
server-test 71.20% <ø> (-0.13%) ⬇️
unittest 45.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 02-23-fix_page_properties_flaky_tests branch from bd7a11f to 658bef1 Compare February 23, 2024 13:20
@pengx17 pengx17 changed the base branch from canary to 02-23-chore_downgrade_react-virtuoso_to_4.6.3 February 23, 2024 13:20
@Brooooooklyn Brooooooklyn force-pushed the 02-23-chore_downgrade_react-virtuoso_to_4.6.3 branch from 76dae38 to 9e7406e Compare February 23, 2024 13:55
@pengx17 pengx17 force-pushed the 02-23-fix_page_properties_flaky_tests branch from 658bef1 to 78eeb17 Compare February 23, 2024 14:02
@Brooooooklyn Brooooooklyn changed the base branch from 02-23-chore_downgrade_react-virtuoso_to_4.6.3 to canary February 23, 2024 14:05
Copy link

graphite-app bot commented Feb 23, 2024

Merge activity

@pengx17 pengx17 force-pushed the 02-23-fix_page_properties_flaky_tests branch from 78eeb17 to c16e4d4 Compare February 23, 2024 14:14
@graphite-app graphite-app bot merged commit c16e4d4 into canary Feb 23, 2024
34 of 36 checks passed
@graphite-app graphite-app bot deleted the 02-23-fix_page_properties_flaky_tests branch February 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants