Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: right sidepanel open on focus #5901

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 26, 2024

fix TOV-614
Should not show sidepanel on focusing inner elemenets

Copy link

graphite-app bot commented Feb 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@pengx17 pengx17 marked this pull request as ready for review February 26, 2024 03:31
Copy link

nx-cloud bot commented Feb 26, 2024

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.40%. Comparing base (7d73145) to head (cc2d97e).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5901      +/-   ##
==========================================
- Coverage   64.41%   64.40%   -0.01%     
==========================================
  Files         360      360              
  Lines       19969    19969              
  Branches     1706     1706              
==========================================
- Hits        12863    12862       -1     
- Misses       6885     6886       +1     
  Partials      221      221              
Flag Coverage Δ
server-test 71.32% <ø> (ø)
unittest 45.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 26, 2024

Merge activity

fix TOV-614
Should not show sidepanel on focusing inner elemenets
@pengx17 pengx17 force-pushed the xp/02-26-fix_right_sidepanel_open_on_focus branch from 5bad61e to cc2d97e Compare February 26, 2024 03:43
@graphite-app graphite-app bot merged commit cc2d97e into canary Feb 26, 2024
34 of 36 checks passed
@graphite-app graphite-app bot deleted the xp/02-26-fix_right_sidepanel_open_on_focus branch February 26, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants