Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page info styles #5910

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: page info styles #5910

merged 1 commit into from
Feb 26, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 26, 2024

fix inconsistent styles compared to the one defined in figma
fix #5904
fix #5903

Copy link

graphite-app bot commented Feb 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

nx-cloud bot commented Feb 26, 2024

@pengx17 pengx17 marked this pull request as ready for review February 26, 2024 10:17
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.31%. Comparing base (6ccc4f1) to head (2295685).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5910      +/-   ##
==========================================
- Coverage   64.41%   64.31%   -0.10%     
==========================================
  Files         360      360              
  Lines       19969    19969              
  Branches     1706     1705       -1     
==========================================
- Hits        12863    12844      -19     
- Misses       6885     6904      +19     
  Partials      221      221              
Flag Coverage Δ
server-test 71.20% <ø> (-0.13%) ⬇️
unittest 45.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 02-26-fix_page_info_styles branch 2 times, most recently from 51205e5 to 01fe644 Compare February 26, 2024 13:00
@github-actions github-actions bot added the test Related to test cases label Feb 26, 2024
Copy link

graphite-app bot commented Feb 26, 2024

Merge activity

fix inconsistent styles compared to the one defined in figma
fix #5904
fix #5903
@graphite-app graphite-app bot merged commit 2295685 into canary Feb 26, 2024
34 of 36 checks passed
@graphite-app graphite-app bot deleted the 02-26-fix_page_info_styles branch February 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Tag Selector UI updates Page Info UI detail​
2 participants