Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): date formatter timezone issue #5936

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 28, 2024

date seems not hornoring the locale browser's locale when parsing date string like "2024-02-28".
fixed by using dayjs instead.

Fix incorrect journal title issue

Copy link

graphite-app bot commented Feb 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 28, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

nx-cloud bot commented Feb 28, 2024

@pengx17 pengx17 marked this pull request as ready for review February 28, 2024 03:49
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.05%. Comparing base (9e09166) to head (27f2209).

Files Patch % Lines
packages/frontend/core/src/utils/intl-formatter.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5936      +/-   ##
==========================================
+ Coverage   63.96%   64.05%   +0.08%     
==========================================
  Files         364      364              
  Lines       20035    20035              
  Branches     1713     1714       +1     
==========================================
+ Hits        12815    12833      +18     
+ Misses       7001     6983      -18     
  Partials      219      219              
Flag Coverage Δ
server-test 71.33% <ø> (+0.12%) ⬆️
unittest 43.97% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 28, 2024

Merge activity

date seems not hornoring the locale browser's locale when parsing date string like "2024-02-28".
fixed by using dayjs instead.

Fix incorrect journal title issue
@pengx17 pengx17 force-pushed the xp/02-28-fix_core_date_formatter_timezone_issue branch from a9c67f5 to 27f2209 Compare February 28, 2024 04:27
@graphite-app graphite-app bot merged commit 27f2209 into canary Feb 28, 2024
33 of 36 checks passed
@graphite-app graphite-app bot deleted the xp/02-28-fix_core_date_formatter_timezone_issue branch February 28, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants