Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove vite-tsconfig-paths #5960

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 29, 2024

It will block storybook from running.
related to aleclarson/vite-tsconfig-paths#132

We are not actually using vite-tsconfig-paths now because we rely on package.json's export field to do path mapping.

Copy link

graphite-app bot commented Feb 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 29, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added docs Improvements or additions to documentation mod:component test Related to test cases labels Feb 29, 2024
Copy link

nx-cloud bot commented Feb 29, 2024

@pengx17 pengx17 marked this pull request as ready for review February 29, 2024 07:38
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.81%. Comparing base (6f8a4d7) to head (752c858).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5960   +/-   ##
=======================================
  Coverage   63.81%   63.81%           
=======================================
  Files         364      364           
  Lines       20039    20039           
  Branches     1699     1699           
=======================================
  Hits        12788    12788           
  Misses       7034     7034           
  Partials      217      217           
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 43.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 29, 2024

Merge activity

It will cause storybook from running.
related to aleclarson/vite-tsconfig-paths#132

We are not actually using `vite-tsconfig-paths` now because we rely on package.json's export field to do path mapping.
@Brooooooklyn Brooooooklyn force-pushed the 02-29-fix_remove_vite-tsconfig-paths branch from c99af6f to 752c858 Compare February 29, 2024 07:59
@graphite-app graphite-app bot merged commit 752c858 into canary Feb 29, 2024
39 of 43 checks passed
@graphite-app graphite-app bot deleted the 02-29-fix_remove_vite-tsconfig-paths branch February 29, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation mod:component test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants