Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add animation for history preview #5966

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 29, 2024

🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented Feb 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Feb 29, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added test Related to test cases app:core labels Feb 29, 2024
@pengx17 pengx17 marked this pull request as ready for review February 29, 2024 10:56
Copy link

nx-cloud bot commented Feb 29, 2024

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.81%. Comparing base (78ce30d) to head (d4e78dd).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5966      +/-   ##
==========================================
- Coverage   63.91%   63.81%   -0.10%     
==========================================
  Files         364      364              
  Lines       20039    20039              
  Branches     1700     1699       -1     
==========================================
- Hits        12807    12788      -19     
- Misses       7015     7034      +19     
  Partials      217      217              
Flag Coverage Δ
server-test 71.04% <ø> (-0.13%) ⬇️
unittest 43.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice
Copy link
Member

🤔 a little strange, cc @hwangdev97 @zanwei

Copy link
Member

@EYHN EYHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Copy link

graphite-app bot commented Feb 29, 2024

Merge activity

@EYHN EYHN force-pushed the xp/02-29-feat_add_animation_for_history_preview branch from a6f8e27 to d4e78dd Compare February 29, 2024 14:08
Copy link
Collaborator Author

pengx17 commented Feb 29, 2024

🤔 a little strange, cc @hwangdev97 @zanwei

let me tune it a bit later

@graphite-app graphite-app bot merged commit d4e78dd into canary Feb 29, 2024
39 of 42 checks passed
@graphite-app graphite-app bot deleted the xp/02-29-feat_add_animation_for_history_preview branch February 29, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants