Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): set journal's really created time #5968

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Feb 29, 2024

closes #5958;

This makes the creation date of the journal correspond to the date, and the creation time is the real creation time.

Copy link

graphite-app bot commented Feb 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

CatsJuice commented Feb 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice marked this pull request as ready for review February 29, 2024 12:24
Copy link

nx-cloud bot commented Feb 29, 2024

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.31%. Comparing base (3fcbfe4) to head (358e1e9).

Files Patch % Lines
packages/frontend/core/src/hooks/use-journal.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5968      +/-   ##
==========================================
+ Coverage   62.12%   62.31%   +0.19%     
==========================================
  Files         443      440       -3     
  Lines       20986    20907      -79     
  Branches     1848     1836      -12     
==========================================
- Hits        13037    13028       -9     
+ Misses       7730     7660      -70     
  Partials      219      219              
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 41.64% <0.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EYHN EYHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bit strange to modify the creation time. Do we really need to modify the creation time? @hwangdev97

@hwangdev97
Copy link
Member

I think it's a bit strange to modify the creation time. Do we really need to modify the creation time? @hwangdev97

after hidden the empty journal on page list, maybe we can show the real creation time 🤔. Do you think so @CatsJuice

Copy link
Member Author

I think it's a bit strange to modify the creation time. Do we really need to modify the creation time? @hwangdev97

after hidden the empty journal on page list, maybe we can show the real creation time 🤔. Do you think so @CatsJuice

Even if we use the real creation time, there still could be multiple journals created in one day. I think our purpose to modify created time is to avoid this situation.

Copy link

graphite-app bot commented Mar 5, 2024

Merge activity

closes #5958;

This makes the creation date of the journal correspond to the date, and the creation time is the real creation time.
@Brooooooklyn Brooooooklyn force-pushed the catsjuice/fix/journal-create-time branch from 1d899db to 358e1e9 Compare March 5, 2024 03:37
@graphite-app graphite-app bot merged commit 358e1e9 into canary Mar 5, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/journal-create-time branch March 5, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Journals create time error​
4 participants