-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): set journal's really created time #5968
Conversation
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CatsJuice and the rest of your teammates on Graphite |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 358e1e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #5968 +/- ##
==========================================
+ Coverage 62.12% 62.31% +0.19%
==========================================
Files 443 440 -3
Lines 20986 20907 -79
Branches 1848 1836 -12
==========================================
- Hits 13037 13028 -9
+ Misses 7730 7660 -70
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a bit strange to modify the creation time. Do we really need to modify the creation time? @hwangdev97
after hidden the empty journal on page list, maybe we can show the real creation time 🤔. Do you think so @CatsJuice |
Even if we use the real creation time, there still could be multiple journals created in one day. I think our purpose to modify created time is to avoid this situation. |
Merge activity
|
closes #5958; This makes the creation date of the journal correspond to the date, and the creation time is the real creation time.
1d899db
to
358e1e9
Compare
closes #5958;
This makes the creation date of the journal correspond to the date, and the creation time is the real creation time.