Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): fix storybook test #5970

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(storybook): fix storybook test #5970

merged 1 commit into from
Mar 1, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Feb 29, 2024

No description provided.

Copy link

graphite-app bot commented Feb 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review February 29, 2024 14:45
Copy link
Member Author

EYHN commented Feb 29, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added test Related to test cases app:core labels Feb 29, 2024
Copy link

nx-cloud bot commented Feb 29, 2024

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 63.80%. Comparing base (d4e78dd) to head (a231884).

Files Patch % Lines
...ges/frontend/core/src/hooks/use-navigate-helper.ts 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5970      +/-   ##
==========================================
- Coverage   63.81%   63.80%   -0.01%     
==========================================
  Files         364      364              
  Lines       20039    20044       +5     
  Branches     1699     1700       +1     
==========================================
+ Hits        12788    12790       +2     
- Misses       7034     7038       +4     
+ Partials      217      216       -1     
Flag Coverage Δ
server-test 71.04% <ø> (+<0.01%) ⬆️
unittest 43.89% <9.09%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 1, 2024

Merge activity

@graphite-app graphite-app bot merged commit a231884 into canary Mar 1, 2024
39 of 42 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/stroy branch March 1, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants