Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize history animation #5973

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 1, 2024

  • adjust timing
  • make sure card do not show the bottom border on transitioning
🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented Mar 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 1, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

nx-cloud bot commented Mar 1, 2024

@pengx17 pengx17 marked this pull request as ready for review March 1, 2024 03:16
@pengx17 pengx17 requested review from CatsJuice and zanwei March 1, 2024 03:16
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (de939bb) to head (a1ea19f).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5973      +/-   ##
==========================================
- Coverage   63.89%   63.80%   -0.10%     
==========================================
  Files         364      364              
  Lines       20044    20044              
  Branches     1701     1700       -1     
==========================================
- Hits        12808    12789      -19     
- Misses       7019     7038      +19     
  Partials      217      217              
Flag Coverage Δ
server-test 71.04% <ø> (-0.13%) ⬇️
unittest 43.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EYHN EYHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like the page content is flickering every time animation

Copy link
Collaborator Author

pengx17 commented Mar 1, 2024

It feels like the page content is flickering every time animation

I guess this is because page content is only rendered for the current rendered element.

Copy link

graphite-app bot commented Mar 1, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants