Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): separate runtimeConfig for e2e tests and deployment #5976

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Mar 1, 2024

Prior to modification, it will function for both deploy and e2e-test. Consequently, allowLocalWorkspace is also set to true in the production environment.
https://github.com/toeverything/AFFiNE/actions/runs/8093473180/job/22116199541#step:5:120

Copy link

graphite-app bot commented Mar 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

JimmFly commented Mar 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 1, 2024

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (a1ea19f) to head (ffda9a0).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5976   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files         364      364           
  Lines       20044    20044           
  Branches     1700     1700           
=======================================
  Hits        12789    12789           
  Misses       7038     7038           
  Partials      217      217           
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 43.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0301/fix-create-workspace branch from 442c469 to a9e8151 Compare March 1, 2024 06:35
@JimmFly JimmFly changed the title fix(core): adjust runtimeConfig feat(core): separate runtimeConfig for e2e tests and deployment Mar 1, 2024
Copy link

graphite-app bot commented Mar 3, 2024

Merge activity

Prior to modification, it will function for both `deploy` and `e2e-test`. Consequently, `allowLocalWorkspace` is also set to `true` in the production environment.
https://github.com/toeverything/AFFiNE/actions/runs/8093473180/job/22116199541#step:5:120
@Brooooooklyn Brooooooklyn force-pushed the jimmfly/0301/fix-create-workspace branch from a9e8151 to ffda9a0 Compare March 3, 2024 12:00
@graphite-app graphite-app bot merged commit ffda9a0 into canary Mar 3, 2024
38 of 42 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0301/fix-create-workspace branch March 3, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants