Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): dont break workspace when page load failed #5988

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 2, 2024

No description provided.

Copy link

graphite-app bot commented Mar 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Mar 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@EYHN EYHN marked this pull request as ready for review March 2, 2024 14:48
Copy link

nx-cloud bot commented Mar 2, 2024

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.33%. Comparing base (ee54e00) to head (d935cf9).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5988   +/-   ##
=======================================
  Coverage   62.33%   62.33%           
=======================================
  Files         439      439           
  Lines       20901    20901           
  Branches     1834     1834           
=======================================
  Hits        13028    13028           
  Misses       7654     7654           
  Partials      219      219           
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 41.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 4, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/fix/page-load-error branch from 571eb9a to d935cf9 Compare March 4, 2024 11:33
@graphite-app graphite-app bot merged commit d935cf9 into canary Mar 4, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/page-load-error branch March 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants