Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): resize and reorder split-view #5994

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Mar 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

CatsJuice commented Mar 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice marked this pull request as ready for review March 4, 2024 01:52
Copy link

nx-cloud bot commented Mar 4, 2024

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 10.40000% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 62.31%. Comparing base (7b31363) to head (2275eee).

Files Patch % Lines
...re/src/modules/workbench/view/split-view/panel.tsx 4.65% 41 Missing ⚠️
...c/modules/workbench/view/split-view/split-view.tsx 3.33% 29 Missing ⚠️
...d/core/src/modules/workbench/entities/workbench.ts 0.00% 21 Missing ⚠️
...odules/workbench/view/split-view/resize-handle.tsx 5.88% 16 Missing ⚠️
...core/src/modules/workbench/view/workbench-root.tsx 0.00% 3 Missing ⚠️
...ontend/core/src/modules/workbench/entities/view.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5994      +/-   ##
==========================================
- Coverage   62.41%   62.31%   -0.10%     
==========================================
  Files         438      440       +2     
  Lines       20908    20906       -2     
  Branches     1832     1836       +4     
==========================================
- Hits        13050    13028      -22     
- Misses       7636     7659      +23     
+ Partials      222      219       -3     
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 41.65% <10.40%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/rightsidebar branch 2 times, most recently from f0b7ed5 to 9d1515a Compare March 4, 2024 05:57
@CatsJuice CatsJuice force-pushed the catsjuice/feat/workbench-view-operation branch from 49ee54d to 4f53606 Compare March 4, 2024 06:01
@CatsJuice CatsJuice requested review from EYHN and pengx17 March 4, 2024 06:08
@EYHN EYHN force-pushed the eyhn/feat/rightsidebar branch 2 times, most recently from b9e79c2 to c599715 Compare March 4, 2024 06:42
Copy link
Collaborator

pengx17 commented Mar 4, 2024

image.png

there's some style issues on windows

@EYHN EYHN changed the base branch from eyhn/feat/rightsidebar to canary March 4, 2024 06:50
Copy link
Member Author

we planned to handle responsive header later

@CatsJuice CatsJuice force-pushed the catsjuice/feat/workbench-view-operation branch 2 times, most recently from 5e56e01 to 4879351 Compare March 4, 2024 08:48
@github-actions github-actions bot added the test Related to test cases label Mar 4, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/feat/workbench-view-operation branch from bbf3393 to b9a3d1a Compare March 4, 2024 10:11
Copy link

graphite-app bot commented Mar 4, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/feat/workbench-view-operation branch from b9a3d1a to 2275eee Compare March 4, 2024 11:20
@graphite-app graphite-app bot merged commit 2275eee into canary Mar 4, 2024
40 of 43 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/workbench-view-operation branch March 4, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:i18n Related to i18n test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants