Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): do not open external links in the browser for internal links in electron #5997

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 4, 2024

No description provided.

Copy link

graphite-app bot commented Mar 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Mar 4, 2024
@pengx17 pengx17 marked this pull request as ready for review March 4, 2024 06:42
Copy link

nx-cloud bot commented Mar 4, 2024

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.41%. Comparing base (c599715) to head (7b31363).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5997   +/-   ##
=======================================
  Coverage   62.41%   62.41%           
=======================================
  Files         438      438           
  Lines       20908    20908           
  Branches     1832     1832           
=======================================
  Hits        13050    13050           
  Misses       7636     7636           
  Partials      222      222           
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 41.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 4, 2024

Merge activity

@EYHN EYHN force-pushed the 03-04-fix_electron_do_not_open_external_links_in_the_browser_for_internal_links_in_electron branch from 0e45a37 to 7b31363 Compare March 4, 2024 09:39
@graphite-app graphite-app bot merged commit 7b31363 into canary Mar 4, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the 03-04-fix_electron_do_not_open_external_links_in_the_browser_for_internal_links_in_electron branch March 4, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants