Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): electron updater issues #6005

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 4, 2024

Copy link

graphite-app bot commented Mar 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Mar 4, 2024
Copy link

nx-cloud bot commented Mar 4, 2024

@pengx17 pengx17 marked this pull request as ready for review March 4, 2024 15:07
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.12%. Comparing base (a9be19c) to head (3fcbfe4).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6005   +/-   ##
=======================================
  Coverage   62.12%   62.12%           
=======================================
  Files         443      443           
  Lines       20986    20986           
  Branches     1848     1848           
=======================================
  Hits        13037    13037           
  Misses       7730     7730           
  Partials      219      219           
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 41.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 5, 2024

Merge activity

- generate-yml.js does not filter files correctly
- add version to generated bundles
- change `.AppImage` to `.appimage`. See https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/providers/Provider.ts#L88
@Brooooooklyn Brooooooklyn force-pushed the 03-04-fix_electron_electron_updater_issues branch from f76e03f to 3fcbfe4 Compare March 5, 2024 03:28
@graphite-app graphite-app bot merged commit 3fcbfe4 into canary Mar 5, 2024
38 of 42 checks passed
@graphite-app graphite-app bot deleted the 03-04-fix_electron_electron_updater_issues branch March 5, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants